From ac4393fcb43a04d71b9816b67958158244a94edf Mon Sep 17 00:00:00 2001 From: cmoyates Date: Sun, 1 Mar 2026 05:55:01 -0330 Subject: [PATCH] docs: clarify pos_embed parameter intent in HieraBackbone Co-Authored-By: Claude Opus 4.6 --- src/corridorkey_mlx/model/hiera.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/corridorkey_mlx/model/hiera.py b/src/corridorkey_mlx/model/hiera.py index 9c7b591..1533270 100644 --- a/src/corridorkey_mlx/model/hiera.py +++ b/src/corridorkey_mlx/model/hiera.py @@ -388,7 +388,8 @@ class HieraBackbone(nn.Module): # Patch embedding self.patch_embed = HieraPatchEmbed() - # Positional embedding (loaded from checkpoint, interpolated at load time) + # Positional embedding — placeholder overwritten by load_checkpoint(). + # Declared as mx.array so load_weights() can assign it; frozen via .eval(). self.pos_embed = mx.zeros((1, _prod(self.tokens_spatial_shape), EMBED_DIM)) # Build all 24 blocks