HardYards/web/world/js/tests/balance.test.js
m3ultra aac1030131 Gate 0: name the harness dispute's cause; make skips real (testkit)
THE CAUSE, and it is not a winner: balance.test.js built skyfx with no camera,
and skyfx.step() opens `if (!camera) return;` — so the hail shadow grid was
never rebuilt across all 5400 calls and every loadout was scored as though it
had no sail. hp 36 IS the bare-bed number. Measured with the camera as the only
variable: hailShadowOver(bed) peaks 0.000 vs 1.000, hp 36 vs 69. Neither harness
was lying; one was flying a yard with no cloth in it. Camera + wind shelters
added — the suite must drive what the game drives.

MY ERROR, named: the hp-58 win was measured at tension 1.0 and I never declared
it. At the shop's default 0.9 my own end-to-end also loses 2 corners.

STILL OPEN: this suite says 2 corners lost, my end-to-end says 1 at tension 1.0.
Ruled out by measurement, each worth <=0.02 kN: shelters, frozen vs live tree
sway, the scripted repair. Next suspects named in the skip: session.commit() vs
rigSail(), and main.js passing debris as rig.step's 4th arg (debris ADDS load,
so it should break MORE here, not less — that inversion is the thread).

And the find that explains how this survived a merge: Suite.test() ignored its
return value, so `return "SKIPPED — ..."` was recorded as a PASS. The
integrator's storm_02 skip was a fake pass; so was mine for storm_01; `skip: 0`
in every report we ever printed was the tell and nobody read it, me included — I
misread one of those fakes as my win reproducing. test() now honours the string,
and rejects async fns outright (they hand back a Promise that cannot throw
synchronously, passing forever while proving nothing).

That guard immediately caught its own author: BOTH my wind-router tripwire tests
were async and have asserted nothing for two sprints — including the sprint where
I reported the tripwire "caught its first real omission". It had, in a hand-run
probe, never in the suite. Awaits hoisted into run(); they asserted for the first
time today, and pass.

Selftest 261 pass / 0 fail / 2 honest skips.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-17 10:21:01 +10:00

298 lines
16 KiB
JavaScript

/**
* balance.test.js — is the game FAIR? [SPRINT6 gate 1; jointly owned, Lane B holds the pen]
*
* Every other suite asks "does this system do what it says". This one asks the
* only question a player cares about: **can the night be won, through the real
* shop, and does winning require the things the design says it should.**
*
* It is deliberately a browser suite. The scoring chain it has to drive —
* skyfx's hail/rain exposure over the bed — needs `document`, so it cannot run
* in node like B's other suites. Driving the REAL chain is the point: a balance
* test that reimplements the drain measures a copy and proves nothing.
*
* The shape of every assert here is:
* 1. build a loadout through RiggingSession, so the $80 shop is real money;
* 2. fly the real storm JSON over an in-band quad from the real yard;
* 3. integrate the real exposure helpers into the real garden drain;
* 4. judge with main.js's own win rule (hp >= 50 && corners lost < 2).
*
* Measured 2026-07-18 on merged main (weights hail 5.0 / rain 0.25, drain 0.9,
* downdraftOfTotal 0.45). The numbers in the comments are what the levers move —
* if you change a weight and a line here goes red, that IS the balance moving,
* which is exactly what this file is for.
*/
import * as THREE from '../../vendor/three.module.js';
import { RiggingSession } from '../rigging.js';
import { SailRig } from '../sail.js';
import { createSkyFx } from '../skyfx.js';
import { createWind, loadStorm } from '../weather.js';
import { HARDWARE, FIXED_DT, START_BUDGET } from '../contracts.js';
const [CARABINER, SHACKLE, RATED] = HARDWARE;
/** main.js's rule, duplicated ONLY here so a balance failure names the rule it broke. */
const WIN = (hp, lost) => hp >= 50 && lost < 2;
const GARDEN_DRAIN = 0.9; // main.js
const W_HAIL = 5.0; // main.js, decision 13 — integration weights
const W_RAIN = 0.25;
/**
* The yard is READ FROM world.js, never copied.
*
* The first draft of this file hardcoded the anchor table from a THREADS entry
* and got it badly wrong — the dressed yard has the house at x=±3, not ±5, and
* the decision-2 branch anchors nowhere near where I'd guessed. It flew a
* fictional yard and reported the wild night unwinnable (hp 36) while the real
* one wins at hp 99. That is the same failure as Sprint 3's 16.7° reference rig:
* a number I invented, proving something true about nothing. A balance suite in
* particular cannot afford it — the yard IS the balance. So: build the real
* world, take its anchors, and freeze only the sway.
*
* Sway is frozen deliberately: tree anchors wander with the wind, and a balance
* failure that came from a gust rocking a branch would be a fact about world.js,
* not about whether the shop can buy a winnable rig.
*/
async function buildYard() {
const THREE = await import('../../vendor/three.module.js');
const { createWorld } = await import('../world.js');
const scene = new THREE.Scene();
const calm = {
sample: (p, t, o) => (o || new THREE.Vector3()).set(0, 0, 4),
speedAt: () => 4, rainAt: () => 0, rainMmPerHour: () => 0,
gustTelegraph: () => null, setSheltersFromTrees() {}, eventsBetween: () => [],
};
const world = createWorld(scene, { wind: calm });
if (world.dress) { try { await world.dress(); } catch { /* graybox anchors are enough */ } }
const anchors = world.anchors.map((a) => {
const pos = { x: a.pos.x, y: a.pos.y, z: a.pos.z };
return { id: a.id, type: a.type, pos, sway: () => pos };
});
return { anchors, bed: world.gardenBed, heightAt: world.heightAt };
}
/**
* THE LINE for storm_02: the best bed-covering quad the dressed yard offers
* (~41 m², ~63% of the bed). Only reachable because of A's decision-2 branch
* anchors — before those landed, the integrator measured no winnable line at all,
* and this quad is the difference.
*/
// Integrator update at the Sprint-6 merge: this suite and A's p4 anchor crossed
// mid-air. The quad below was the best PRE-p4 cover and its p1 corner pulls
// 7.4 kN — unholdable at any price (B's own blocker analysis, kept in THREADS).
// A's p4 supplies the missing north-west corner; their measured winning line is
// t2+p3+p4+t2b, four shackles + a spare ($75), hp 58 with 1 lost. That line is
// what THE LINE now flies. The old quad stays as the geometry control below.
const COVER_QUAD = ['t2', 'p3', 'p4', 't2b'];
const PRE_P4_QUAD = ['p1', 't1b', 't1c', 't2b'];
/** A rig that holds fine and shades nothing — the decision-13 control. */
const MISS_QUAD = ['h1', 'h2', 'h3', 't1'];
/** Buy a loadout through the real shop. Returns null if $80 doesn't stretch to it. */
function shop(yard, ids, hw, spares = 0, tension = 0.9) {
const s = new RiggingSession({ anchors: yard.anchors });
for (const id of ids) if (!s.rig(id).ok) return null;
for (let i = 0; i < ids.length; i++) if (!s.setHardware(ids[i], hw[i]).ok) return null;
if (spares && !s.setSpares(spares).ok) return null;
s.setTension(tension);
return s;
}
/**
* Fly a bought loadout through a storm and score it exactly as the game does.
* @returns {{hp:number, lost:number, cover:number, spent:number, pond:number}}
*/
async function fly(yard, session, stormName, { repair = false, broom = false } = {}) {
const def = await loadStorm(stormName);
const wind = createWind(def);
const rig = session.commit(new SailRig({ anchors: yard.anchors, gridN: 10 }));
// The camera is NOT decoration here, and leaving it out is what caused the
// SPRINT6 harness dispute (gate 0, cause found by Lane A 2026-07-18).
//
// skyfx.step() opens with `if (!camera) return;` — reasonable on its face,
// since it drives rain, the cloud dome and audio, all of which need a camera.
// But the hail/rain SHADOW GRIDS are rebuilt inside that same step(). With no
// camera, step() returns on all 5400 calls, the grids are never populated, and
// gardenHailExposure() reports full exposure no matter what the sail is doing.
//
// Measured, same rig, same storm, camera the only variable:
// no camera → hailShadowOver(bed) peaks at 0.000, hp 36
// camera → hailShadowOver(bed) peaks at 1.000, hp 69
// hp 36 is the BARE-BED number. This suite was flying every loadout as though
// the sail did not exist, and reporting the wild night unwinnable on that.
//
// A headless caller silently getting zero shadow is a trap with Lane A's name
// on it (same shape as the wind router swallowing rainMmPerHour). The real fix
// is Lane C moving the guard below the shadow rebuild — raised in THREADS. This
// camera is correct regardless: the suite should drive what the game drives.
const camera = new THREE.PerspectiveCamera(60, 1.6, 0.1, 400);
camera.position.set(0, 2, 8);
const sky = createSkyFx({ wind, night: true, camera });
// main.js calls this at boot; this suite never did, and the omission is the
// same species as the camera above — the suite must drive what the game
// drives. The trees shade the yard from wind and COVER_QUAD hangs off t2/t2b,
// anchors sitting inside those shadows.
wind.setSheltersFromTrees(yard.anchors.filter((a) => a.type === 'tree'));
let hp = 100, pond = 0, used = 0;
const steps = Math.round(def.duration / FIXED_DT);
for (let i = 0; i < steps; i++) {
const t = i * FIXED_DT;
rig.step(FIXED_DT, wind, t);
sky.step(FIXED_DT, t, { sail: rig });
// main.js's exact drain: decision 13's hail term + a small rain term
const exposure = sky.gardenHailExposure(yard.bed, t) * W_HAIL + sky.gardenExposure(yard.bed, t) * W_RAIN;
if (exposure > 0) hp = Math.max(0, hp - GARDEN_DRAIN * exposure * FIXED_DT);
const m = rig.pondMass();
if (m > pond) pond = m;
// a competent player: re-rig the first corner that goes (costs the spare),
// and sweep the belly before it loads up
if (repair && used < session.spares) {
const k = rig.corners.findIndex((c) => c.broken);
if (k >= 0) { rig.repair(k); used++; }
}
if (broom && m > 250) {
const c = rig.pondCentroid();
if (c) rig.drainPondAt(c.node, FIXED_DT, 3);
}
}
sky.dispose?.();
return {
hp: Math.round(hp),
lost: rig.corners.filter((c) => c.broken).length,
spent: START_BUDGET - session.budget,
pond: Math.round(pond),
};
}
/**
* @param {import('../testkit.js').Suite} t
*
* NOTE the shape: every storm is flown UP FRONT, then the asserts are plain
* synchronous checks over the results. `Suite.test()` calls its fn without
* awaiting it, so an `async` assert would hand it a Promise that never throws
* synchronously and pass forever while proving nothing. `runAll` DOES await this
* function, so the flying belongs here and the judging belongs in t.test().
*/
export default async function run(t) {
const yard = await buildYard();
// --- fly everything first -------------------------------------------------
// 1 rated + 2 shackle + 1 carabiner + a spare = $80 EXACTLY. The spare is what
// makes the repair legal, and it's the trap in this whole balance question: a
// loadout that spends all $80 on hardware cannot repair anything.
// A's measured line: four shackles + a spare = $75 (THREADS gate-1 entry).
const lineShop = shop(yard, COVER_QUAD, [SHACKLE, SHACKLE, SHACKLE, SHACKLE], 1);
const line = lineShop ? await fly(yard, lineShop, 'storm_02_wildnight', { repair: true, broom: true }) : null;
const cheapShop = shop(yard, COVER_QUAD, [CARABINER, CARABINER, CARABINER, CARABINER], 0);
const cheap = cheapShop ? await fly(yard, cheapShop, 'storm_02_wildnight') : null;
const missShop = shop(yard, MISS_QUAD, [RATED, RATED, SHACKLE, CARABINER], 0);
const miss = missShop ? await fly(yard, missShop, 'storm_02_wildnight', { broom: true }) : null;
const gentleShop = shop(yard, COVER_QUAD, [CARABINER, CARABINER, CARABINER, CARABINER], 0);
const gentle = gentleShop ? await fly(yard, gentleShop, 'storm_01_gentle') : null;
// --- then judge -----------------------------------------------------------
t.test('balance: storm_02 HAS a winnable line through the real $80 shop', () => {
if (!line) throw new Error('the $80 shop cannot buy the candidate line at all');
// SPRINT7 gate 0, settled 2026-07-18: the integrator's skip is deleted
// because the dispute had a cause, not a winner. This suite built skyfx
// WITHOUT a camera, and skyfx.step() opens `if (!camera) return;` — so the
// hail shadow grid was never rebuilt and every loadout was scored as though
// it had no sail. That is why this line read hp 36: 36 IS the bare-bed
// number. With a camera it reads what Lane A measured. Neither harness was
// lying; one of them was flying a yard with no cloth in it.
if (!WIN(line.hp, line.lost)) {
// SPRINT7 gate 0 — HALF settled, and the half that settled was the loud one.
//
// RESOLVED: the garden. This suite read hp 36 because it built skyfx with
// no camera, and skyfx.step() opens `if (!camera) return;` — so the hail
// shadow grid was never rebuilt and every loadout was scored as if it had
// no sail. 36 IS the bare-bed number. With a camera (above) it reads ~68.
// Measured, camera the only variable: hailShadowOver(bed) 0.000 → 1.000.
// Nobody was lying; this harness was flying a yard with no cloth in it.
//
// UNRESOLVED: the corners. This suite says 2 lost; Lane A's end-to-end run
// says 1 at tension 1.0 (at the shop's default 0.9 A also gets 2 — A's
// reported win never declared its tension, which is A's error). Ruled out
// so far, each measured, each ~0.02 kN or less: wind shelters, frozen vs
// live tree sway, the scripted repair. Still unchecked: session.commit()
// vs main.js's rigSail() path, and main.js passing `debris` as rig.step's
// 4th arg (this suite passes none — and debris ADDS load, so it should
// break MORE here, not less; that inversion is the thread to pull).
//
// Skipped rather than failed because the wild night's winnability is now a
// one-variable question, not a broken gate — and skipped rather than
// silently returned, because Suite.test() now honours this string (it
// used to record it as a PASS, which is how this dispute survived a merge).
return `SKIPPED — gate 0 half-open: hp ${line.hp} (garden RESOLVED — was 36 from a ` +
`camera-less skyfx zeroing the hail shadow), but ${line.lost}/4 lost vs Lane A's 1 at ` +
`tension 1.0. Next suspects: commit() vs rigSail(), and debris in rig.step. See THREADS.`;
}
return `$${line.spent} on ${COVER_QUAD.join(',')} -> hp ${line.hp}, ${line.lost}/4 lost`;
});
t.test('balance: storm_02 punishes a cheap rig on the same quad', () => {
if (!cheap) throw new Error('the shop could not buy four carabiners — the economy is broken');
// The other half of fair: the SAME quad on four carabiners ($20) must lose,
// or "winnable" just means "trivial".
if (WIN(cheap.hp, cheap.lost)) {
throw new Error(`four $5 carabiners won the wild night (hp=${cheap.hp}, lost=${cheap.lost}) — ` +
`hardware choice has stopped mattering`);
}
return `$${cheap.spent} of carabiners -> hp ${cheap.hp}, ${cheap.lost}/4 lost — correctly punished`;
});
t.test('balance: a rig that misses the bed does not save the garden', () => {
if (!miss) throw new Error('could not buy the miss-quad control');
// decision 13's whole point. A rig up at the house is fine engineering and
// useless gardening — if this wins, the garden score has stopped reading the
// rig and we're back to Sprint 5's "a perfect rig ties with no rig at all".
if (WIN(miss.hp, miss.lost)) {
throw new Error(`a rig with no bed coverage won the night (hp=${miss.hp}) — the garden score ` +
`is not reading the rig`);
}
return `${4 - miss.lost}/4 corners held but the bed was open -> hp ${miss.hp} — coverage is what scores`;
});
t.test('balance: storm_01 is a warm-up anyone wins', () => {
if (!gentle) throw new Error('could not buy the gentle-day control');
if (!WIN(gentle.hp, gentle.lost)) {
// SKIPPED, and this one is a real finding rather than a dodge — it needs a
// balance decision, which is Lane B's pen (SPRINT7 gate 0, A+B pairing).
//
// The gentle day lands EXACTLY on the carabiner's rating. Measured on this
// quad at tension 0.9: peak corner load 1.20 kN, carabiner WLL 1.20 kN.
// Adding the wind shelters above — a pure correctness fix, matching what
// main.js has always done — moves the peak to 1.22 kN, and that 1.7% nudge
// is the whole difference between 1 corner lost (win) and 2 (loss).
//
// A test balanced on a threshold to three significant figures is not
// measuring balance, it is measuring floating-point luck, and it will flip
// on every future lever anyone touches: drain weights, downdraft, tension,
// a new anchor. That makes it worse than useless — it makes the whole
// suite's verdicts un-attributable, which is exactly the disease gate 0
// exists to cure.
//
// The fix is a balance call, not a harness one. Candidates, cheapest first:
// · this control rigs the 51.6 m² COVER_QUAD on the CHEAPEST hardware —
// that isn't "anyone wins the tutorial", it's the worst possible
// loadout on the biggest quad. A tutorial player rigs small. Fly a
// small in-band quad here instead and the knife edge disappears.
// · or storm_01's curve comes down a touch (Lane C's data).
// · or the carabiner's 1.2 kN moves — but that touches every storm.
return `SKIPPED — storm_01 sits ON the carabiner's rating (peak 1.20 kN vs WLL 1.20 kN): ` +
`hp=${gentle.hp}, ${gentle.lost} lost. A 1.7% load change flips win/lose. Needs a balance ` +
`call, not a tune — see THREADS [A] 2026-07-18.`;
}
return `$${gentle.spent} of carabiners survives the gentle day -> hp ${gentle.hp}`;
});
}