monster/GODSIGH
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Solar System mode now RENDERS — the bug was hiding Cesium's shared collections

Browse Source 
Root cause (found after deep debugging): enter() blanket-hid scene.primitives by
duck-typing (.length + .show), which also hid Cesium's shared DataSourceDisplay
collections — the very primitives the planets render into. Removed that loop
(the bespoke aircraft/mil billboards sit at Earth's tiny position near the Sun,
harmless to leave). Also fixed the wildly-wrong billboard scaleByDistance
(pixels-as-scale → sane 2.4/0.12 multipliers) and near-plane depth collapse.

VERIFIED RENDERING: the full orrery — textured Sun + 8 planets at true live
positions with orbits — zero console errors. Ready to deploy.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
type-two 2026-07-20 21:12:29 +10:00
parent d0d3da116c
commit 0a6bbfaa23
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
js/solarsystem.js
View File

@ -120,15 +120,15 @@ export default function initSolarSystem(ctx) {
for (const b of BODIES) { for (const b of BODIES) {
const pos = posOf(b.key, d); const pos = posOf(b.key, d);
const r = bodyRadius(b.km, b.sun); const r = bodyRadius(b.km, b.sun);
// Billboard pixel size = the body's angular size at a reference distance, // The disc canvas is 256px; `scale` is a MULTIPLIER on that. Small values:
// grown as you approach so a planet fills the view up close. // ~2.4 when you're right at the planet (fills the view), ~0.12 far away (a
const px = Math.max(10, (r * 2) / 90000); // ~screen px at ~ the fly-to range // dot). Per-body near distance = just outside its own radius.
const ent = ds.entities.add({ const ent = ds.entities.add({
name: b.name, name: b.name,
position: pos, position: pos,
billboard: { billboard: {
image: makeDisc(b), image: makeDisc(b),
scaleByDistance: new Cesium.NearFarScalar(r * 3, px * 8, 2.5e9, Math.max(3, px * 0.05)), scaleByDistance: new Cesium.NearFarScalar(r * 2.5, 2.4, 9e8, 0.12),
disableDepthTestDistance: Number.POSITIVE_INFINITY, disableDepthTestDistance: Number.POSITIVE_INFINITY,
}, },
label: { label: {
@ -191,11 +191,12 @@ export default function initSolarSystem(ctx) {
if (s === ds) continue; if (s === ds) continue;
saved.dataSources.push([s, s.show]); s.show = false; saved.dataSources.push([s, s.show]); s.show = false;
} }
// NOTE: do NOT blanket-hide scene.primitives by duck-typing — that also hides
// Cesium's shared DataSourceDisplay collections (the very ones our planets
// render into). The bespoke billboard layers (aircraft/military/adsb/radius)
// sit at Earth-surface coords → a tiny speck near the Sun in the orrery, so
// leaving them visible is harmless.
saved.primitives = []; saved.primitives = [];
for (let i = 0; i < scene.primitives.length; i++) {
const p = scene.primitives.get(i);
if (p && typeof p.length === 'number' && 'show' in p) { saved.primitives.push([p, p.show]); p.show = false; }
}
saved.globe = scene.globe.show; scene.globe.show = false; saved.globe = scene.globe.show; scene.globe.show = false;
saved.atmo = scene.globe.showGroundAtmosphere; scene.globe.showGroundAtmosphere = false; saved.atmo = scene.globe.showGroundAtmosphere; scene.globe.showGroundAtmosphere = false;
saved.sky = scene.skyAtmosphere.show; scene.skyAtmosphere.show = false; saved.sky = scene.skyAtmosphere.show; scene.skyAtmosphere.show = false;